Op/aan merkingen aub.

Door RobinPeters op 26-12-2009 01:39

509 views

Beste,

Ik zou willen vragen of jullie eens over mijn kleine :P pagina willen kijken.
Ik zou graag wat tips willen ontvangen.

Alvast Bedankt!


<?php

/**
 * @author Robin Peters
 * @copyright 2010
 */

?>

<h3><?php echo $leagues["fullname"]; ?> - Servers</h3>
<ul>

<?php
$sql = "SELECT gid, name FROM games";

if(!$res = mysql_query($sql)){
    trigger_error(mysql_error().'<br />In query: '.$sql);
}

elseif(mysql_num_rows($res) == 0){
    echo $msg[4];
}

else{
    while($game = mysql_fetch_assoc($res)){
        
        ?>
		<li><a href="index.php?mode=servers&gid=<?php echo $game["gid"]; ?>"><?php echo $game["name"]; ?> - Servers</a></li>			
        <?php
    }
}

?>

</ul>

<?php

if (isset($_GET["gid"]) && $_GET["gid"] != "") {
    
    $gid = $_GET["gid"];
    
    $sql = "SELECT * FROM servers WHERE gameid = $gid";
    
    if(!$res = mysql_query($sql)){
        trigger_error(mysql_error().'<br />In query: '.$sql);
    }
    
    elseif(mysql_num_rows($res) == 0){
        echo $msg[5];
    }
    
    else{
        while($server = mysql_fetch_assoc($res)){
            
            ?>
            <h3><?php echo $leagues["fullname"]; ?> - <?php echo $server["name"]; ?></h3>
    		<ul>
    			<img src="<?php echo $server["img"]; ?>">
    			<li> &nbsp; <b>Server Name</b>:    <?php echo $server["name"]; ?>		  </li>
    			<li> &nbsp; <b>Server Address</b>: <?php echo $server["addr"]; ?>		  </li>
    			<li> &nbsp; <b>Server Port</b>:    <?php echo $server["port"]; ?>		  </li>
    			<li> &nbsp; <b>Server Type</b>:    <?php echo $server["type"]; ?>	      </li>
    			<li> &nbsp; <b>Max Players</b>:    <?php echo $server["maxplayers"]; ?>	  </li>
    			<li> &nbsp; <b>Round Time</b>:     <?php echo $server["time"]; ?> Minutes </li>
    		</ul><br />			
            <?php
        }
    }
    
}

?>

vdleije .

26-12-2009 01:57

Zo zou ik hem doen:

Verbeterd:

- Enkele quotes in $_GET en $_POST
- mysql errors anders opgelost
- sql injection tegengegaan (mysql_real_escape_string())
- kijken of iets leeg is: empty() i.p.v. == ""

<?php

/**
 * @author Robin Peters
 * @copyright 2010
 */

?>

<h3><?php echo $leagues['fullname']; ?> - Servers</h3>
<ul>

<?php
$sql = mysql_query("SELECT gid, name FROM games") or die(mysql_error());

if(mysql_num_rows($sql) == 0){
    echo $msg[4];
}
else{
    while($game = mysql_fetch_assoc($sql)){
        
        ?>
        <li><a href="index.php?mode=servers&gid=<?php echo $game['gid']; ?>"><?php echo $game['name']; ?> - Servers</a></li>            
        <?php
    }
}

?>

</ul>

<?php

if (isset($_GET['gid']) && !empty($_GET['gid'])) {
    
    $sql = mysql_query("SELECT * FROM servers WHERE gameid = '".mysql_real_escape_string($_GET['gid'])."'") or die(mysql_error());
    
if(mysql_num_rows($sql) == 0){
        echo $msg[5];
    }
else{
        while($server = mysql_fetch_assoc($sql)){
            
            ?>
            <h3><?php echo $leagues['fullname']; ?> - <?php echo $server['name']; ?></h3>
            <ul>
                <img src="<?php echo $server['img']; ?>">
                <li> &nbsp; <b>Server Name</b>:    <?php echo $server['name']; ?>          </li>
                <li> &nbsp; <b>Server Address</b>: <?php echo $server['addr']; ?>          </li>
                <li> &nbsp; <b>Server Port</b>:    <?php echo $server['port']; ?>          </li>
                <li> &nbsp; <b>Server Type</b>:    <?php echo $server['type']; ?>          </li>
                <li> &nbsp; <b>Max Players</b>:    <?php echo $server['maxplayers']; ?>      </li>
                <li> &nbsp; <b>Round Time</b>:     <?php echo $server['time']; ?> Minutes </li>
            </ul><br />            
            <?php
        }
    }
    
}

?>

RobinPeters

26-12-2009 02:46

Bedankt voor de tips!

Loran DP

26-12-2009 03:02

waarom dit:


<?PHp
//////
?>
            <h3><?php echo $leagues['fullname']; ?> - <?php echo $server['name']; ?></h3>
            <ul>
                <img src="<?php echo $server['img']; ?>">
                 <li> &nbsp; <b>Server Address</b>: <?php echo $server['addr']; ?>          </li>
                <li> &nbsp; <b>Server Port</b>:    <?php echo $server['port']; ?>          </li>
                <li> &nbsp; <b>Server Type</b>:    <?php echo $server['type']; ?>          </li>
                <li> &nbsp; <b>Max Players</b>:    <?php echo $server['maxplayers']; ?>      </li>
                <li> &nbsp; <b>Round Time</b>:     <?php echo $server['time']; ?> Minutes </li>
            </ul><br />';      
            </ul><br />            
            <?php

en niet dit:


<?PHp
//////

           echo"<h3>".$leagues['fullname']." - ".$server['name']."</h3>\n\r";
           echo'<ul>
                <img src="<?php echo $server['img']; ?>">
               <li> &nbsp; <b>Server Name</b>:    '. $server['name'].'</li>
                <li> &nbsp; <b>Server Address</b>: '.$server['addr'].'</li>
                <li> &nbsp; <b>Server Port</b>:    '.$server['port'].'</li>
                <li> &nbsp; <b>Server Type</b>:    '. $server['type'].'</li>
                <li> &nbsp; <b>Max Players</b>:   '.$server['maxplayers'].' </li>
                <li> &nbsp; <b>Round Time</b>:     '.$server['time'].'Minutes </li>
                <li> &nbsp; <b>Server Name</b>:    <?php echo $server['name']; ?>          </li>

vdleije .

26-12-2009 10:52

Tjah, dat is iets wat je in Dreamweaver liever doet :P (ik wel) tijdens het bewerken van tabellen. Je ziet gelijk welke uitput het heeft. Weet niet of het in dit geval ook zo is..

Reageren

Inloggen om te reageren