Is mijn class een goede class?

Midas

'var' is PHP 4. Die mag je dus weglaten. :-)

Karl

Het is netter om een apart db class te maken.

Storeman

Je moet bedenken dat je een echte gebruiker hebt en wat deze kan doen.

<?
class user {
	private $uId;		// The user id
	private $uName;		// The user name
	private $uPass;		// The user password
	
	private var $qLimit;	// The limit for an query
	
	/* Functions to set values */
	// These functions sets data for uId, uName, uPass en qLimit
	function set_uId ($value) {
		$this->uId		=	$value;
	}
	function set_uName ($value) {
		$this->uName	=	$value;
	}
	function set_uPass ($value) {
		$this->uPass	=	$value;
	}
	function set_qLimit ($value){
		$this->qLimit	=	$value;
	}
	
	// Functions to use data
	// This function creates an user.
	// Needs atleast uName and uPass to be set
	public function createUser() {
		mysql_query("INSERT INTO users (uName, uPass) VALUES ('".$this->uName."','".$this->uPass."')");
	}
	
	// This function deletes an user
	// Needs atleast uId to be set
	public function deleteUser() {
		mysql_query("DELETE FROM users WHERE uId='".$this->uId."'");
	}
	
	// This function selects 1 or more users
	// Needs for normal atleast the limit and for specific the uId
	public function selectUser ($type) {
		if($type == 'specific'){
			mysql_query("SELECT * FROM users WHERE uId='".$this->uId."'");
		} elseif($type == 'normal'){
			mysql_query("SELECT * FROM users LIMIT ".$this->qLimit);
		}
	}
}
?>

<?

class user extends dbConnect {
	private $uId;		// The user id
	private $uName;		// The user name
	private $uPass;		// The user password
	
	/* Functions to set values */
	// These functions sets data for uId, uName, uPass en qLimit
	function set_uId ($value) {
		$this->uId		=	$value;
	}
	function set_uName ($value) {
		$this->uName	=	$value;
	}
	function set_uPass ($value) {
		$this->uPass	=	$value;
	}
	
	// Functions to use data
	public function create() {
		if(empty($this->uName) || empty($this->uPass)){
			return 'The username or password was not set.';
		} else {
			$sql	=	"INSERT INTO users (uName, uPass) VALUES ('".$this->uName."', '".$this->uPass."')";
			parent::query($sql);
		}
	}
	
	// This function needs atleast uId to be set
	public function delete() {
		if(empty($this->uId)){
			return 'User id was not set.';
		} else {
			$sql	=	"DELETE FROM users WHERE uId='".$this->uId."'";
			parent::query($sql);
		}
	}
}
?>