Loginscript nie veilig

Overzicht Reageren

Sponsored by: Vacatures door Monsterboard

Hoekman Jonas

Hoekman Jonas

25/05/2006 20:55:00
Quote Anchor link
geachte het volgende loginscript is niet veilig als register globals aanstaat iemand een oplossing ervoor ?
Register globals afzetten is niet mogelijk.
Code (php)
PHP script in nieuw venster Selecteer het PHP script
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
<?
    /**************************
    *      txtAuth v1.0       *
    *   ©2004 - Thomas Love   *
    *   http://txtbox.co.za   *
    **************************/
    

include "../config.php" ;//dit is aangepast voor het
include ('lang/'.$taal.'.php') ;//dit is aangepast voor het cms
//we gaan ons config bestand includen zodat de gebruikersnaam en paswoord daaruit komen


// Default config options.
// Override these by pasting them in the form $tacfg['....'] above the require() code in the actual
// page to be protected.

// Username and password (dit word uit de config file gelezen dus niet aanpassen !
//this comes out the config file don't change !
$rmgroup = 'default';
$tacfgd['uname'] =  $usersname_cms ;

// tacfgd['uname'] = $usersname_cms ;//voor cms aangepast komt uit config
$tacfgd['pword'] =  $pasword_cms ;// = $pasword_cms ;//voor cms aangepast komt uit config

// Title of page.
$tacfgd['title'] = $lang['login']['login'];

// Text to appear just above login form.
$tacfgd['helptext'] = $lang['login']['fill_in'];


// Set to true to enable the optional remember-me feature, which stores encrypted login details to
// allow users to be logged-in automatically on their return. Turn off for a little extra security.
$tacfgd['allowrm'] = false;

// If you have multiple protected pages, and there's more than one username / password combination,
// you need to group each combination under a distinct rmgroup so that the remember-me feature
// knows which login details to use.
$tacfgd['rmgroup'] = 'default';

// Set to true if you use your own sessions within your protected page, to stop txtAuth interfering.
// In this case, you _must_ call session_start() before you require() txtAuth. Logging out will not
// destroy the session, so that is left up to you.
$tacfgd['ownsessions'] = false;



foreach ($tacfgd as $key => $val) {
  if (!isset($tacfg[$key])) $tacfg[$key] = $val;
}

if (!$tacfg['ownsessions']) {
  session_name('txtauth');
  session_start();
}


// Logout attempt made. Deletes any remember-me cookie as well
if (isset($_GET['txtlogout']) || isset($_POST['txtlogout'])) {
  setcookie('txtauth'.$rmgroup, '', time()-86400*14);
  if (!$tacfg['ownsessions']) {
    $_SESSION = array();
    session_destroy();
  }
  else $_SESSION['txtauthin'] = false;
}
// Login attempt made
elseif (isset($_POST['login'])) {
  if ($_POST['uname'] == $tacfg['uname'] && (sha1($_POST['pword'])) == $tacfg['pword']) {
    $_SESSION['txtauthin'] = true;
    if (isset($_POST['rm'])) {
      // Set remember-me cookie for 2 weeks
      setcookie('txtauth'.$rmgroup, sha1($tacfg['uname'].$tacfg['pword']), time()+86400*14);
    }
  }
  else $err = 'can\'t login wrong user/pas combination';
}
/*
if((isset($_POST['pword'])) and (isset($_GET['tacfgd']['uname'])) ){// Jonas hoekman edit for more safety
 $err = 'can\'t login wrong user/pas combination';// Jonas hoekman edit for more safety
    
    }
    
    if((isset($_POST['pword'])) and (isset($_GET['tacfgd']['pword']))){// Jonas hoekman edit for more safety
 $err = 'can\'t login wrong user/pas combination';// Jonas hoekman edit for more safety
    
    }
    if((isset($_POST['pword'])) and (isset($_POST['tacfgd']['uname'])) ){// Jonas hoekman edit for more safety
 $err = 'can\'t login wrong user/pas combination';// Jonas hoekman edit for more safety
    
    }
    
    if((isset($_POST['pword'])) and (isset($_POST['tacfgd']['pword']))){// Jonas hoekman edit for more safety
 $err = 'can\'t login wrong user/pas combination';// Jonas hoekman edit for more safety
    
    }
    */
// Remember-me cookie exists
elseif (isset($_COOKIE['txt'.$rmgroup])) {
  if (sha1($tacfg['uname'].$tacfg['pword']) == $_COOKIE['txtauth_'.$rmgroup] && $tacfg['allowrm']) {
    $_SESSION['txtauthin'] = true;
  }
  else $err = 'Remember-me cookie disabled or invalid';
}
if (! isset ($_SESSION['txtauthin'])) { //isset toegevoegd
?>
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<title><?=$tacfg['title']?></title>

</head>

<body>
<div style="font-size: 14pt;" align="center"><?=$tacfg['title']?></div>
<hr width="300" size="1" noshade>
<p>
<div align="center" class="grey">
<?=$tacfg['helptext']?>
</div>
<p>
<?
if (isset($_SERVER['REQUEST_URI'])) $action = $_SERVER['REQUEST_URI'];
else $action = $_SERVER['PHP_SELF'].'?'.$_SERVER['QUERY_STRING'];
if (strpos($action, 'txtlogout=1', strpos($action, '?')) !== false) $action = str_replace('txtlogout=1', '', $action);
?>
<form name="txtauth" action="<?=$action?>" method="post">
<table border="0" cellpadding="4" cellspacing="0" bgcolor="#efefef" align="center" style="border: #dedede 3px double;">
<?=(isset($err))?'<tr><td colspan="2" align="center"><font color="red">'.$err.'</font></td></tr>':''?>
<?if (isset($tacfg['uname'])) {?>
<tr><td>username:</td><td><input type="text" name="uname" value="" size="20" maxlength="100" class="txtbox"></td></tr>
<?}?>
<tr><td>password:</td><td><input type="password" name="pword" value="" size="20" maxlength="100" class="txtbox"></td></tr>
<?if ($tacfg['allowrm']) {?>
<tr><td align="left"><input type="submit" name="login" value=" login ">
</td><td align="right"><input type="checkbox" name="rm" id="rm"><label for="rm">Auto login</label></td></tr>
<?} else {?>
<tr><td colspan="2" align="center"><input type="submit" name="login" value=" login "></td></tr>
<?}?>
</table>
</form>

</body>
</html>
<?
  // Don't delete this!
  exit();
}
?>
Gewijzigd op 01/01/1970 01:00:00 door Hoekman Jonas
 
PHP hulp

PHP hulp

16/04/2024 15:08:57
 
Erik Rijk

Erik Rijk

25/05/2006 20:59:00
Quote Anchor link
ik vind je opbouw al heel wazig.
werkt het uberhaubt wel?
 
Hoekman Jonas

Hoekman Jonas

26/05/2006 11:13:00
Quote Anchor link
Er zaten nog wat fouten in heb deze eruit gehaalt.
Dus nu zou het moeten werken.

M.v.g. Jonas Hoekman
 
Andries Louw Wolthuizen

Andries Louw Wolthuizen

24/09/2006 22:03:00
Quote Anchor link
Code (php)
PHP script in nieuw venster Selecteer het PHP script
1
2
3
4
5
6
7
8
9
10
11
12
13
14
<?php
if (ini_get('register_globals'))
{
   foreach($GLOBALS as $s_variable_name => $m_variable_value)
   {
       if (!in_array($s_variable_name, array('GLOBALS', 'argv', 'argc', '_FILES', '_COOKIE', '_POST', '_GET', '_SERVER', '_ENV', '_SESSION', 's_variable_name', 'm_variable_value')))
       {
           unset($GLOBALS[$s_variable_name]);
       }
   }
   unset($GLOBALS['s_variable_name']);
   unset($GLOBLAS['m_variable_value']);
}
?>

Bovenaan je script, dan unset hij alle variabelen die geset zijn door register globals.
Gewijzigd op 01/01/1970 01:00:00 door Andries Louw Wolthuizen
 



Overzicht Reageren

 
 

Om de gebruiksvriendelijkheid van onze website en diensten te optimaliseren maken wij gebruik van cookies. Deze cookies gebruiken wij voor functionaliteiten, analytische gegevens en marketing doeleinden. U vindt meer informatie in onze privacy statement.