login-class
Deze class heb ik gemaakt met beperkte kennis van classes, en deze plaats ik hier voor jullie, en om deze te laten controleren.
Zit deze class goed in elkaar?
En wat kan eraan verbeterd worden?
Mijn verstand van classes is nog licht beperkt, dus hier heb ik alleen basis elementen in gebruik.
Code (php)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
<?php
/*************************************************************************
:: LOGIN CLASS ::
NOTE: This login class is used for user authorization.
Author : Jelle Posthuma
Date : 21 November 2008
*************************************************************************/
class login{
var $hash = '';
var $memberID = 0;
var $user = '';
var $pass = '';
var $error = '';
var $rememberLogin = false;
var $enableDebug = true;
var $debug = array();
function doLogin( $byForm = '' ){
if( ! $this->loggedIn() ){
if( $this->readCookies() ){
$this->setSessions();
}else if( ! empty( $byForm ) ){
if( $this->validateFields( $byForm ) ){
$this->hash = $this->setHash();
if( $this->rememberLogin ){
if( !$this->setCookies() ){
$this->error = 'Cookies niet gemaakt!';
return false;
}
}
$this->setSessions();
$this->updateLoginDate();
if( empty( $this->error ) ) header( "Location: index.php" );
return true;
}else{
return false;
}
}
}
}
function validateFields( $byForm ){
if( !empty( $byForm[ md5( date( 'dmY' ) ) . 'user' ] ) && !empty( $byForm[ md5( date( 'dmY' ) ) . 'pass' ] ) ){
$this->user = $byForm[ md5( date( 'dmY' ) ) . 'user' ];
$this->pass = $byForm[ md5( date( 'dmY' ) ) . 'pass' ];
$this->rememberLogin = ( $_POST[ 'autoLogin' ] == 'yes' ) ? true : false ;
if( $this->validateDB() ){
return true;
}else{
$this->error = 'De door u ingevoerde gebruikersnaam of wachtwoord is incorrect.';
}
}else{
$this->error = 'Één of meer velden zijn niet ingevuld.';
}
}
function validateDB(){
$sql = "SELECT
memberID
FROM
members
WHERE
passWordMD5 = '" . md5( $this->user ) . "'
AND
userName = '" . $this->pass . "'
";
$res = mysql_query( $sql );
if( mysql_num_rows( $res ) > 0 ){
$row = mysql_fetch_assoc( $res );
$this->memberID = $row[ 'memberID' ];
return true;
}else{
$this->error = 'Uw gegevens kunnen niet gevalideerd worden.';
return false;
}
}
function setHash(){
return md5( $this->memberID . $this->user . $this->pass . date( 'dmYHis' ) );
}
function setCookies(){
if(
setcookie( PREFIX . '_userID' , $this->memberID , time() + ( 60 * 60 * 24 * 365 ) ) &&
setcookie( PREFIX . '_user' , $this->user , time() + ( 60 * 60 * 24 * 365 ) ) &&
setcookie( PREFIX . '_pass' , $this->pass , time() + ( 60 * 60 * 24 * 365 ) ) &&
setcookie( PREFIX . '_lKey' , $this->hash , time() + ( 60 * 60 * 24 * 365 ) )
){
return true;
}else{
return false;
}
}
function setSessions(){
return true;
}
function readHash(){
return true;
}
function readCookies(){
return false;
}
function cookiesExists(){
if(
!empty( $_COOKIE[ PREFIX . '_userID' ] ) &&
!empty( $_COOKIE[ PREFIX . '_user' ] ) &&
!empty( $_COOKIE[ PREFIX . '_pass' ] ) &&
!empty( $_COOKIE[ PREFIX . '_lKey' ] )
){
return true;
}else{
return false;
}
}
function sessionExists(){
return false;
}
function validateCookieHash(){
$sql = "SELECT
memberID
FROM
members
WHERE
memberID = '" . $_COOKIE[ PREFIX . '_userID' ] . "'
AND
loginKey = '" . $_COOKIE[ PREFIX . '_lKey' ] . "'
AND
userName = '" . $_COOKIE[ PREFIX . '_user' ] . "'
AND
passWord = '" . $_COOKIE[ PREFIX . '_pass' ] . "'
";
$res = mysql_query( $sql )or die( $sql . '<br />' . mysql_error() );
if( mysql_num_rows( $res ) == 1 ){
return true;
}else{
return false;
}
}
function validateSessionHash(){
$sql = "SELECT
memberID
FROM
members
WHERE
memberID = '" . $_SESSION[ PREFIX . '_userID' ] . "'
AND
loginKey = '" . $_SESSION[ PREFIX . '_lKey' ] . "'
AND
userName = '" . $_SESSION[ PREFIX . '_user' ] . "'
AND
passWord = '" . $_SESSION[ PREFIX . '_pass' ] . "'
";
$res = mysql_query( $sql );
if( mysql_num_rows( $res ) == 1 )
return true;
else
return false;
}
function loggedIn(){
if( ( $this->sessionExists() && $this->validateSessionHash() ) || ( $this->cookiesExists() && $this->validateCookieHash() ) ){
if( !defined( "USER_RAW" ) ) define( "USER_RAW" , "" );
if( !defined( "USERNAME" ) ) define( "USERNAME" , $_COOKIE[ PREFIX . '_user' ] );
if( !defined( "USERID" ) ) define( "USERID" , $_COOKIE[ PREFIX . '_userID' ] );
if( !defined( "LOGIN" ) ) define( "LOGIN" , true );
return true;
}else{
if( !defined( "LOGIN" ) ) define("LOGIN",false);
return false;
}
}
function updateLoginDate(){
$sql = "UPDATE
members
SET
loginKey = '" . $this->hash . "',
loginDate = NOW()
WHERE
memberID = " . $this->memberID . "
";
mysql_query( $sql );
}
function logout(){
setcookie( PREFIX . '_userID' , '' , time() - 3600 );
setcookie( PREFIX . '_user' , '' , time() - 3600 );
setcookie( PREFIX . '_pass' , '' , time() - 3600 );
setcookie( PREFIX . '_lKey' , '' , time() - 3600 );
}
}
?>
/*************************************************************************
:: LOGIN CLASS ::
NOTE: This login class is used for user authorization.
Author : Jelle Posthuma
Date : 21 November 2008
*************************************************************************/
class login{
var $hash = '';
var $memberID = 0;
var $user = '';
var $pass = '';
var $error = '';
var $rememberLogin = false;
var $enableDebug = true;
var $debug = array();
function doLogin( $byForm = '' ){
if( ! $this->loggedIn() ){
if( $this->readCookies() ){
$this->setSessions();
}else if( ! empty( $byForm ) ){
if( $this->validateFields( $byForm ) ){
$this->hash = $this->setHash();
if( $this->rememberLogin ){
if( !$this->setCookies() ){
$this->error = 'Cookies niet gemaakt!';
return false;
}
}
$this->setSessions();
$this->updateLoginDate();
if( empty( $this->error ) ) header( "Location: index.php" );
return true;
}else{
return false;
}
}
}
}
function validateFields( $byForm ){
if( !empty( $byForm[ md5( date( 'dmY' ) ) . 'user' ] ) && !empty( $byForm[ md5( date( 'dmY' ) ) . 'pass' ] ) ){
$this->user = $byForm[ md5( date( 'dmY' ) ) . 'user' ];
$this->pass = $byForm[ md5( date( 'dmY' ) ) . 'pass' ];
$this->rememberLogin = ( $_POST[ 'autoLogin' ] == 'yes' ) ? true : false ;
if( $this->validateDB() ){
return true;
}else{
$this->error = 'De door u ingevoerde gebruikersnaam of wachtwoord is incorrect.';
}
}else{
$this->error = 'Één of meer velden zijn niet ingevuld.';
}
}
function validateDB(){
$sql = "SELECT
memberID
FROM
members
WHERE
passWordMD5 = '" . md5( $this->user ) . "'
AND
userName = '" . $this->pass . "'
";
$res = mysql_query( $sql );
if( mysql_num_rows( $res ) > 0 ){
$row = mysql_fetch_assoc( $res );
$this->memberID = $row[ 'memberID' ];
return true;
}else{
$this->error = 'Uw gegevens kunnen niet gevalideerd worden.';
return false;
}
}
function setHash(){
return md5( $this->memberID . $this->user . $this->pass . date( 'dmYHis' ) );
}
function setCookies(){
if(
setcookie( PREFIX . '_userID' , $this->memberID , time() + ( 60 * 60 * 24 * 365 ) ) &&
setcookie( PREFIX . '_user' , $this->user , time() + ( 60 * 60 * 24 * 365 ) ) &&
setcookie( PREFIX . '_pass' , $this->pass , time() + ( 60 * 60 * 24 * 365 ) ) &&
setcookie( PREFIX . '_lKey' , $this->hash , time() + ( 60 * 60 * 24 * 365 ) )
){
return true;
}else{
return false;
}
}
function setSessions(){
return true;
}
function readHash(){
return true;
}
function readCookies(){
return false;
}
function cookiesExists(){
if(
!empty( $_COOKIE[ PREFIX . '_userID' ] ) &&
!empty( $_COOKIE[ PREFIX . '_user' ] ) &&
!empty( $_COOKIE[ PREFIX . '_pass' ] ) &&
!empty( $_COOKIE[ PREFIX . '_lKey' ] )
){
return true;
}else{
return false;
}
}
function sessionExists(){
return false;
}
function validateCookieHash(){
$sql = "SELECT
memberID
FROM
members
WHERE
memberID = '" . $_COOKIE[ PREFIX . '_userID' ] . "'
AND
loginKey = '" . $_COOKIE[ PREFIX . '_lKey' ] . "'
AND
userName = '" . $_COOKIE[ PREFIX . '_user' ] . "'
AND
passWord = '" . $_COOKIE[ PREFIX . '_pass' ] . "'
";
$res = mysql_query( $sql )or die( $sql . '<br />' . mysql_error() );
if( mysql_num_rows( $res ) == 1 ){
return true;
}else{
return false;
}
}
function validateSessionHash(){
$sql = "SELECT
memberID
FROM
members
WHERE
memberID = '" . $_SESSION[ PREFIX . '_userID' ] . "'
AND
loginKey = '" . $_SESSION[ PREFIX . '_lKey' ] . "'
AND
userName = '" . $_SESSION[ PREFIX . '_user' ] . "'
AND
passWord = '" . $_SESSION[ PREFIX . '_pass' ] . "'
";
$res = mysql_query( $sql );
if( mysql_num_rows( $res ) == 1 )
return true;
else
return false;
}
function loggedIn(){
if( ( $this->sessionExists() && $this->validateSessionHash() ) || ( $this->cookiesExists() && $this->validateCookieHash() ) ){
if( !defined( "USER_RAW" ) ) define( "USER_RAW" , "" );
if( !defined( "USERNAME" ) ) define( "USERNAME" , $_COOKIE[ PREFIX . '_user' ] );
if( !defined( "USERID" ) ) define( "USERID" , $_COOKIE[ PREFIX . '_userID' ] );
if( !defined( "LOGIN" ) ) define( "LOGIN" , true );
return true;
}else{
if( !defined( "LOGIN" ) ) define("LOGIN",false);
return false;
}
}
function updateLoginDate(){
$sql = "UPDATE
members
SET
loginKey = '" . $this->hash . "',
loginDate = NOW()
WHERE
memberID = " . $this->memberID . "
";
mysql_query( $sql );
}
function logout(){
setcookie( PREFIX . '_userID' , '' , time() - 3600 );
setcookie( PREFIX . '_user' , '' , time() - 3600 );
setcookie( PREFIX . '_pass' , '' , time() - 3600 );
setcookie( PREFIX . '_lKey' , '' , time() - 3600 );
}
}
?>
Database dump van de login table:
Code (php)
1
2
3
4
5
6
7
8
9
10
2
3
4
5
6
7
8
9
10
CREATE TABLE `members` (
`memberID` int(10) NOT NULL AUTO_INCREMENT,
`groupID` int(10) NOT NULL,
`loginKey` varchar(255) NOT NULL,
`loginDate` datetime NOT NULL,
`userName` varchar(255) NOT NULL,
`passWord` varchar(255) NOT NULL,
`passWordMD5` varchar(255) NOT NULL
PRIMARY KEY (`memberID`)
) ENGINE=MyISAM DEFAULT CHARSET=latin1 AUTO_INCREMENT=1 ;
`memberID` int(10) NOT NULL AUTO_INCREMENT,
`groupID` int(10) NOT NULL,
`loginKey` varchar(255) NOT NULL,
`loginDate` datetime NOT NULL,
`userName` varchar(255) NOT NULL,
`passWord` varchar(255) NOT NULL,
`passWordMD5` varchar(255) NOT NULL
PRIMARY KEY (`memberID`)
) ENGINE=MyISAM DEFAULT CHARSET=latin1 AUTO_INCREMENT=1 ;